Change in vdsm[master]: Invalidate filters on HSMs before rescanning extended VG
danken at redhat.com
danken at redhat.com
Wed Oct 30 17:26:08 UTC 2013
Dan Kenigsberg has posted comments on this change.
Change subject: Invalidate filters on HSMs before rescanning extended VG
......................................................................
Patch Set 13: Code-Review-1
(1 comment)
....................................................
File vdsm/storage/hsm.py
Line 2004: boolean
Line 2005: :rtype: dict
Line 2006: """
Line 2007: visibility = self.scanDevicesVisibility(guids)
Line 2008: lvm._lvminfo.invalidateFilter()
can we avoid using a private data member here?
Could you explain why adding a side effect to getDevicesVisibility() is a good thing?
Line 2009: for guid in guids:
Line 2010: if visibility[guid]:
Line 2011: visibility[guid] = (os.stat('/dev/mapper/' + guid).st_mode &
Line 2012: stat.S_IRUSR != 0)
--
To view, visit http://gerrit.ovirt.org/20552
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tomáš Došek <tdosek at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list