Change in vdsm[master]: vm: Pause vm in case volume allocation is greater than lv size

abaron at redhat.com abaron at redhat.com
Wed Oct 30 09:55:42 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: vm: Pause vm in case volume allocation is greater than lv size
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

....................................................
File vdsm/vm.py
Line 4301:                         return
Line 4302: 
Line 4303:                     toExtend.append(vmDrive, physical, alloc)
Line 4304: 
Line 4305:             for vmDrive, physical, alloc in toExtend:
the code here is a duplicate of high write.
There are a couple of nuances but I don't think they matter much.
This should be refactored into a separate function that has the logic once only.
the extra test here of physical > alloc + config... seems applicable to highwrite as well.

You'd probably need to raise an exception in case physical < alloc and catch it in calling method
Line 4306:                 self.log.info('%s = %s/%s error %s phys: %s alloc: %s',
Line 4307:                               vmDrive.alias, vmDrive.domainID,
Line 4308:                               vmDrive.volumeID, err, physical, alloc)
Line 4309:                 self.extendDriveVolume(vmDrive)


-- 
To view, visit http://gerrit.ovirt.org/19719
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id95aa1ed7508218d8ae6a878606cd2d251ac2b05
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list