Change in vdsm[master]: stats: return HA agent score when applicable

gpadgett at redhat.com gpadgett at redhat.com
Tue Oct 29 11:32:17 UTC 2013


Greg Padgett has posted comments on this change.

Change subject: stats: return HA agent score when applicable
......................................................................


Patch Set 7:

(1 comment)

....................................................
File vdsm/API.py
Line 1220:             try:
Line 1221:                 stats['haScore'] = haClient.HAClient().get_local_host_score()
Line 1222:             except Exception:
Line 1223:                 self.log.error("failed to retrieve Hosted Engine HA score",
Line 1224:                                exc_info=True)
Failure here is unexpected and with any luck, rare.  If it does happen, the traceback should help identify where things went wrong.  Changing to use self.log.exception([...])
Line 1225: 
Line 1226:         return {'status': doneCode, 'info': stats}
Line 1227: 
Line 1228:     def setLogLevel(self, level):


-- 
To view, visit http://gerrit.ovirt.org/20126
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdad8accb0660dbdcc8b6e1b83f491c2f89c2d30
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list