Change in vdsm[master]: stats: return HA agent score when applicable

nsoffer at redhat.com nsoffer at redhat.com
Sun Oct 27 22:09:22 UTC 2013


Nir Soffer has posted comments on this change.

Change subject: stats: return HA agent score when applicable
......................................................................


Patch Set 5:

(1 comment)

....................................................
File vdsm/API.py
Line 51: try:
Line 52:     import ovirt_hosted_engine_ha.client.client as ha_client
Line 53:     ha_agent = True
Line 54: except ImportError:
Line 55:     ha_agent = False
Can be little cleaner if you do:

try:
    import ovirt_hosted_engine_ha.client.client as haClient
except ImportError:
    haClient = None

And later:

    if haClient:
        # Use it
Line 56: 
Line 57: # default message for system shutdown, will be displayed in guest
Line 58: USER_SHUTDOWN_MESSAGE = 'System going down'
Line 59: 


-- 
To view, visit http://gerrit.ovirt.org/20126
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdad8accb0660dbdcc8b6e1b83f491c2f89c2d30
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list