Change in vdsm[master]: logging: Add vdsm lvm log

smizrahi at redhat.com smizrahi at redhat.com
Sun Oct 27 14:03:24 UTC 2013


Saggi Mizrahi has posted comments on this change.

Change subject: logging: Add vdsm lvm log
......................................................................


Patch Set 4:

As I told Nir, for log collection you want to turn on logs for all LVM commands in the system. I don't mind someone making a script to make this change as long as it's not in VDSM since it's a general issue.

Since LVM doesn't treat VDSM as a context we shouldn't use it for debugging. We might ignore valuable information. This is especially true since only commands outside of VDSM don't pass though our synch mechanisms and could potentially collide and cause errors that require an actual VDSM run instead of a local check of the parameters.

-- 
To view, visit http://gerrit.ovirt.org/20145
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7081bb8c1b1710dfa36ce56fac9ecd7a90fed1e3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list