Change in vdsm[master]: cleanup: drop several unused local variables

ybronhei at redhat.com ybronhei at redhat.com
Sun Oct 27 06:52:07 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: cleanup: drop several unused local variables
......................................................................


Patch Set 5:

(3 comments)

....................................................
File lib/vdsm/netinfo.py
Line 120:         return (not isHiddenNic(device) and
Line 121:                 not isEnslavedByHiddenBond(device))
Line 122: 
Line 123:     res = [dev for dev in _nic_devices() if isManagedByVdsm(dev)]
Line 124:     return res
if you already clean.. just:

return [dev for dev in _nic_devices() if isManagedByVdsm(dev)]
Line 125: 
Line 126: 
Line 127: def bondings():
Line 128:     """


....................................................
File tests/functional/networkTests.py
Line 379:             firstVlan, firstVlanId = NET_VLANS[0]
Line 380:             status, msg = self.vdsm_net.addNetwork(firstVlan, vlan=firstVlanId,
Line 381:                                                    bond=BONDING_NAME,
Line 382:                                                    nics=nics, opts=opts)
Line 383:             self.assertEquals(status, SUCCESS, msg)
is it related to the cleanup?
Line 384:             with nonChangingOperstate(BONDING_NAME):
Line 385:                 for netVlan, vlanId in NET_VLANS[1:]:
Line 386:                     status, msg = self.vdsm_net.addNetwork(netVlan,
Line 387:                                                            vlan=vlanId,


....................................................
File tests/functional/virtTests.py
Line 84:     fd, path = tempfile.mkstemp()
Line 85:     cmd = [_mkinitrd.cmd, "-f", path, _kernelVer]
Line 86:     rc, _, err = execCmd(cmd, sudo=False)
Line 87:     if rc:
Line 88:         raise SkipTest('Cannot generate the initramfs: %s' % err)
this raise doesn't relate to the cleanup .. separate to tests fix and cleanup if you prefer.
Line 89:     os.chmod(path, 0o644)
Line 90:     return path
Line 91: 
Line 92: 


-- 
To view, visit http://gerrit.ovirt.org/20535
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib81c292f900154819e8852c21ae389c323034999
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list