Change in vdsm[master]: Add additional vgcheck to fix vgextend workflow on HSMs.

sgotliv at redhat.com sgotliv at redhat.com
Fri Oct 25 21:15:00 UTC 2013


Sergey Gotliv has posted comments on this change.

Change subject: Add additional vgcheck to fix vgextend workflow on HSMs.
......................................................................


Patch Set 8:

(2 comments)

....................................................
Commit Message
Line 6: 
Line 7: Add additional vgcheck to fix vgextend workflow on HSMs.
Line 8: 
Line 9: vgscan doesn't return nonzero return code if one or more physical
Line 10: volumes are missed during the _reloadvgs opration. As a result
Can you rephrase "doesn't return nonzero" with something like "return zero even if one...", please.
Line 11: LvmCache doesn't invalidate stale filters and volume group is
Line 12: marked as partial and sefttest fails (host goes to non-operational status).
Line 13: We should call vgck before raising of the exception, because vgck
Line 14: returns error code 5 in case of missed PVs, as a result filters


Line 8: 
Line 9: vgscan doesn't return nonzero return code if one or more physical
Line 10: volumes are missed during the _reloadvgs opration. As a result
Line 11: LvmCache doesn't invalidate stale filters and volume group is
Line 12: marked as partial and sefttest fails (host goes to non-operational status).
selftest
Line 13: We should call vgck before raising of the exception, because vgck
Line 14: returns error code 5 in case of missed PVs, as a result filters
Line 15: are rebuilded with correct uuids. chkVG itself raises
Line 16: storageAccessError if failed, so selftest doesn't have to do it second time.


-- 
To view, visit http://gerrit.ovirt.org/20552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tomáš Došek <tdosek at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list