Change in vdsm[master]: cleanup: drop several unused local variables

danken at redhat.com danken at redhat.com
Fri Oct 25 17:03:31 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: cleanup: drop several unused local variables
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

This patch is growing too quickly and produces too frequent risks. Could you slow down or break it to sub components?

....................................................
File vdsm/storage/blockVolume.py
Line 602:     def newVolumeLease(cls, metaId, sdUUID, volUUID):
Line 603:         cls.log.debug("Initializing volume lease volUUID=%s sdUUID=%s, "
Line 604:                       "metaId=%s", volUUID, sdUUID, metaId)
Line 605:         dom = sdCache.produce(sdUUID)
Line 606:         mdSlot = metaId
?
Line 607: 
Line 608:         leasePath = dom.getLeasesFilePath()
Line 609:         leaseOffset = ((mdSlot + RESERVED_LEASES)
Line 610:                        * dom.logBlkSize * sd.LEASE_BLOCKS)


-- 
To view, visit http://gerrit.ovirt.org/20535
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib81c292f900154819e8852c21ae389c323034999
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list