Change in vdsm[master]: cleanup: Improve networking imports (PEP328)

asegurap at redhat.com asegurap at redhat.com
Fri Oct 25 13:41:44 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: cleanup: Improve networking imports (PEP328)
......................................................................


Patch Set 1:

(4 comments)

Thanks a lot for the review Nir!

>Important cleanup - but mixes many unrelated cleanups.
>
>This patch does much more than promised in the commit message:
>
>  -  Merge multiple imports into one line - this change is wrong, as it makes
>     reviewing import changes harder. If you want to push this evil practice,
>     do this in another patch.
I can very well move it to a separate patch so devs can vote on this specific
issue alone.
>  -  Change import order - not sure why this was done
I'll update the commit message to reflect that I'm fixing the imports in
general, and part of that is to keep them properly sorted.
>  -  Add missing copyright
Totally right, will move that into a separate patch.
>  -  Fix the years in another copyright
This is necessary for the patch. When you touch a file you are supposed to make
sure the the copyright is updated to include the current year in the range.
>
>Please remove anything which is not related to absolute imports.

....................................................
File vdsm/configNetwork.py
Line 32: from .neterrors import ConfigNetworkError
Line 33: from .netmodels import Bond, Bridge, IPv4, IPv6, IpConfig, Nic, Vlan
Line 34: from vdsm.config import config
Line 35: from vdsm import constants, netinfo, utils
Line 36: from vdsm.utils import execCmd
storage.misc.execCmd only puts a storage specific logger on top of utils execCmd (we moved the original there).
Line 37: 
Line 38: CONNECTIVITY_TIMEOUT_DEFAULT = 4
Line 39: 
Line 40: 


....................................................
File vdsm/sourceRouteThread.py
Line 16: #
Line 17: # Refer to the README and COPYING files for full details of the license
Line 18: #
Line 19: from __future__ import absolute_import
Line 20: 
Yeah. This one is unrelated, just my laziness to make an extra patch for that :P
Line 21: import logging
Line 22: import os
Line 23: 
Line 24: import pyinotify


....................................................
File vdsm/tc.py
Line 26: 
Line 27: import ethtool
Line 28: 
Line 29: from vdsm.constants import EXT_TC
Line 30: from vdsm.utils import execCmd
answered in another file.
Line 31: 
Line 32: ERR_DEV_NOEXIST = 2
Line 33: 
Line 34: QDISC_INGRESS = 'ffff:'


....................................................
File vdsm/vdsm-restore-net-config
Line 1: #! /usr/bin/python
Line 2: #
Line 3: # Copyright 2011-2013 Red Hat, Inc.
If I modify the file in 2013 I should update the year in the header.
Line 4: #
Line 5: # This program is free software; you can redistribute it and/or modify
Line 6: # it under the terms of the GNU General Public License as published by
Line 7: # the Free Software Foundation; either version 2 of the License, or


-- 
To view, visit http://gerrit.ovirt.org/20555
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I249cfa0ad734ea45ecbbecbade9daeed6c3adc12
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list