Change in vdsm[master]: iscsiadm: Add debug level option

ewarszaw at redhat.com ewarszaw at redhat.com
Thu Oct 24 13:37:02 UTC 2013


Eduardo has posted comments on this change.

Change subject: iscsiadm: Add debug level option
......................................................................


Patch Set 3: Code-Review-1

"""
Note that the usefulness of these logs is questionable, as one call to iscsiadm can generate 18KB 395 lines log, and all of this is collapsed to one line, replacing \n with \\n, which makes it almost unreadable.
"""

I agree with --author that dumping many times unreadable lines on the vdsm.log only will destroy the vdsm.log.

The whole idea of RFE https://bugzilla.redhat.com/1011075 is questionable, being iscsiadm errors actually logged in vdsm.log and there is no need for logging iscasiadm possitive flows in vdsm.logs.

-- 
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list