Change in vdsm[master]: getFileList() filters files in case incensitive manner

sgotliv at redhat.com sgotliv at redhat.com
Thu Oct 24 10:05:31 UTC 2013


Sergey Gotliv has posted comments on this change.

Change subject: getFileList() filters files in case incensitive manner
......................................................................


Patch Set 1:

(2 comments)

All I need is return all available information about iso and vfd files from VDSM to Engine in order to fix a bug.

My another patch that fixing that issue:
http://gerrit.ovirt.org/#/c/19544/
is approved by not merged - I think it deserves a new status :-).

I have no problem to change the name and signature of this API as Nir wishes, but only if all (and mostly maintainer) will decide that this is the right direction.

....................................................
Commit Message
Line 3: AuthorDate: 2013-10-23 23:36:03 +0300
Line 4: Commit:     Sergey Gotliv <sgotliv at redhat.com>
Line 5: CommitDate: 2013-10-23 23:57:55 +0300
Line 6: 
Line 7: getFileList() filters files in case incensitive manner
Done
Line 8: 
Line 9: Currently Engine is using getIsoList() and getFloppyList() APIs to
Line 10: retrieve the list of iso and floppy files respectively. Both these APIs
Line 11: are working in case incensitive manner but don't provide file


Line 10: retrieve the list of iso and floppy files respectively. Both these APIs
Line 11: are working in case incensitive manner but don't provide file
Line 12: statistics. Changing getFileList(), which is already providing full
Line 13: information about files, to be case incensitive will make it adoption
Line 14: easier.
Done
Line 15: 
Line 16: Change-Id: I550827c7b4c7e11fe09e41745fcc9d91249c6c23


-- 
To view, visit http://gerrit.ovirt.org/20476
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I550827c7b4c7e11fe09e41745fcc9d91249c6c23
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list