Change in vdsm[master]: makedirs should preceed configure_coredump and other init ta...

ybronhei at redhat.com ybronhei at redhat.com
Thu Oct 24 08:58:58 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: makedirs should preceed configure_coredump and other init targets.
......................................................................


Patch Set 2:

(1 comment)

....................................................
Commit Message
Line 3: AuthorDate: 2013-10-23 23:24:32 +0300
Line 4: Commit:     Mooli Tayer <mtayer at redhat.com>
Line 5: CommitDate: 2013-10-23 23:35:24 +0300
Line 6: 
Line 7: makedirs should preceed configure_coredump and other init targets.
It doesn't matter if this fix is necessary for immediate issue or not, 

mkdirs should be the first thing to proceed, to avoid issues in the next steps. If we haven't encountered issues with that, it doesn't mean we don't need to fix the order.

just add more detailed explanation in the commit message
Line 8: 
Line 9: Change-Id: Iab8e343996edb76d1481ab1a466cb6ffcc52f407


-- 
To view, visit http://gerrit.ovirt.org/20475
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab8e343996edb76d1481ab1a466cb6ffcc52f407
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list