Change in vdsm[master]: fix bash ineffective timestamp

danken at redhat.com danken at redhat.com
Wed Oct 23 15:56:27 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: fix bash ineffective timestamp
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

....................................................
File vdsm/vdsm-store-net-config.in
Line 47: 
Line 48: unified_nonnode_persist() {
Line 49:     # Atomic directory copy by using the atomicity of overwriting a link
Line 50:     # (rename syscall).
Line 51:     TIMESTAMP=$(date +%s)$$
It is unlikely, but this timestamp can still have collisions. How about using nanoseconds and/or separing the pic and the sec with a period?
Line 52:     PERS_CONF_SYMLINK=$PERS_NET_CONF_PATH
Line 53:     PERS_CONF_DIR_ROOTNAME="$PERS_CONF_SYMLINK."
Line 54:     PERS_CONF_NEW_DIR="$PERS_CONF_DIR_ROOTNAME$TIMESTAMP"
Line 55:     PERS_CONF_NEW_SYMLINK="$PERS_CONF_SYMLINK.link.$TIMESTAMP"


-- 
To view, visit http://gerrit.ovirt.org/20459
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b4262b4fa242f20f55d03931d8c62b4650a34a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list