Change in vdsm[master]: getVolumeInfo() new implementation.

ewarszaw at redhat.com ewarszaw at redhat.com
Wed Oct 23 09:19:12 UTC 2013


Eduardo has posted comments on this change.

Change subject: getVolumeInfo() new implementation.
......................................................................


Patch Set 7:

(1 comment)

....................................................
File vdsm/storage/volume.py
Line 894:         else:
Line 895:             info = self.metadata2info(meta)
Line 896:             info["capacity"] = str(int(info["size"]) * BLOCK_SIZE)  # Virtual
Line 897:             del info["size"]  # Remove the virtual (by volMD) size [blocks]
Line 898:             if info['mtime'] == "" and self.__class__.__name__ == "FileVolume":
Already discussed by phone.
Line 899:                 info['mtime'] = self.oop.os.stat(self.volumePath).st_mtime
Line 900:             # If image was set to illegal, mark the status same
Line 901:             # (because of VDC constraints)
Line 902:             if info['legality'] == ILLEGAL_VOL:


-- 
To view, visit http://gerrit.ovirt.org/18233
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedcfd84cd0848fbe3aca9f9af45c44c17722055e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990 at gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list