Change in vdsm[master]: ipwrapper: wrap `ip monitor link`

danken at redhat.com danken at redhat.com
Wed Oct 23 08:27:17 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: ipwrapper: wrap `ip monitor link`
......................................................................


Patch Set 1:

(1 comment)

....................................................
File lib/vdsm/ipwrapper.py
Line 352:             device = tokens[1][:-2]
Line 353:             flags = frozenset(tokens[2][1:-1].split(','))
Line 354:             values = dict(tokens[i:i + 2] for i in range(3, len(tokens), 2))
Line 355: 
Line 356:             changes.append(MonitorEvent(device, flags, values.get('state')))
I do not mind adding more fields to the namedtuple. Personally, I prefer that they are added when they are actually needed.

However, if that what it takes to get your ack, I'll add add "master" and "qdisc".
Line 357: 
Line 358:         return changes
Line 359: 
Line 360:     def events(self):


-- 
To view, visit http://gerrit.ovirt.org/20418
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I556459220b09fea035774ad82a0ffa4555efaf7b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list