Change in vdsm[master]: Making getVSize and getVTrueSize SD methods.

danken at redhat.com danken at redhat.com
Tue Oct 22 12:00:35 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Making getVSize and getVTrueSize SD methods.
......................................................................


Making getVSize and getVTrueSize SD methods.

* Units sanitized. The two methods return now size in bytes,
  like st_size.
* getVTrueSize() renamed to getAllocSize().

TODO:
These two method should be unified in a future patch since the
two values are returned in the same call for file volumes and
the two values are identical for block volumes.

Required to reduce the volume size functions proliferation.

Change-Id: I3d9772cedd74431e71d6068399546e1b4aae69e9
Signed-off-by: Eduardo <ewarszaw at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/18202
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Tested-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/volumeTests.py
M vdsm/storage/blockSD.py
M vdsm/storage/blockVolume.py
M vdsm/storage/fileSD.py
M vdsm/storage/fileVolume.py
M vdsm/storage/hsm.py
M vdsm/storage/volume.py
7 files changed, 49 insertions(+), 50 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/18202
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3d9772cedd74431e71d6068399546e1b4aae69e9
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990 at gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list