Change in vdsm[master]: Introducing configurator package in vdsm-tool

Alon Bar-Lev alonbl at redhat.com
Tue Oct 22 09:41:20 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: Introducing configurator package in vdsm-tool
......................................................................


Patch Set 16:

(2 comments)

....................................................
File lib/vdsm/tool/configurator.py
Line 24: 
Line 25: from vdsm import utils
Line 26: import vdsm.tool
Line 27: from vdsm.tool import service
Line 28: from vdsm.constants import P_VDSM_EXEC, DISKIMAGE_GROUP
I think this only makes it more complex... I expect to have argument to do the restart and not execute this 1+ N times.
Line 29: 
Line 30: 
Line 31: class _ModuleConfigure(object):
Line 32:     def __init__(self):


Line 184:     """
Line 185:     args = parse_configure_args()
Line 186:     for c in __configurers and (not args.module or c.getName() in args.module):
Line 187:         sys.stdout.write("Configuring %s\n" % (c.getName()))
Line 188:         c.configure(force=args.force)
still my previous comment about atomic was not taken into account.
Line 189:     return 0
Line 190: 
Line 191: 
Line 192: @vdsm.tool.expose("isconfigured")


-- 
To view, visit http://gerrit.ovirt.org/20100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list