Change in vdsm[master]: Ensure active LVs are refreshed before use.

lyarwood at redhat.com lyarwood at redhat.com
Tue Oct 22 08:12:12 UTC 2013


Lee Yarwood has posted comments on this change.

Change subject: Ensure active LVs are refreshed before use.
......................................................................


Patch Set 4:

(3 comments)

....................................................
Commit Message
Line 3: AuthorDate: 2013-10-04 14:32:48 +0100
Line 4: Commit:     Lee Yarwood <lyarwood at redhat.com>
Line 5: CommitDate: 2013-10-18 17:25:19 +0100
Line 6: 
Line 7: Ensure active LVs are refreshed before use.
This change should only refresh active LVs, inactive LVs will be activated as normal without an additional refresh after this. However I'll add the lvm: tag to the message.
Line 8: 
Line 9: At present active LVs are trusted to correctly represent the correct
Line 10: state of a given LV. This may not be the case if the LV has been
Line 11: modified by another host since the LV was activated.


....................................................
File vdsm/storage/lvm.py
Line 1124: 
Line 1125: 
Line 1126: def activateLVs(vgName, lvNames):
Line 1127:     lvNames = _normalizeargs(lvNames)
Line 1128:     _setLVAvailability(vgName, lvNames, "y --refresh")
Not quite, the issue is that we can't trust that the layout of dm devices that form the LV are correct *if* the LV is already active. I'll add a comment with this.
Line 1129: 
Line 1130: 
Line 1131: def deactivateLVs(vgName, lvNames):
Line 1132:     lvNames = _normalizeargs(lvNames)


Line 1124: 
Line 1125: 
Line 1126: def activateLVs(vgName, lvNames):
Line 1127:     lvNames = _normalizeargs(lvNames)
Line 1128:     _setLVAvailability(vgName, lvNames, "y --refresh")
Same here, we can always file  a RFE for this and update the call later.
Line 1129: 
Line 1130: 
Line 1131: def deactivateLVs(vgName, lvNames):
Line 1132:     lvNames = _normalizeargs(lvNames)


-- 
To view, visit http://gerrit.ovirt.org/19871
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list