Change in vdsm[master]: Introducing configurator package in vdsm-tool

ybronhei at redhat.com ybronhei at redhat.com
Mon Oct 21 16:17:09 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: Introducing configurator package in vdsm-tool
......................................................................


Patch Set 15:

(1 comment)

....................................................
File lib/vdsm/tool/configurator.py
Line 83:         """
Line 84:         libvirt configuration (--force to force reconfigure also when
Line 85:         configured)
Line 86:         """
Line 87:         if super(LibvirtModuleConfigure, self).configure(force):
didn't understand the sentence. you mean having this operation on upper class is wrong and you prefer having the code in both configure functions, right?
Line 88:             libvirt_related_services = ["supervdsmd", "libvirtd"]
Line 89:             service_should_start = []
Line 90:             for srv in libvirt_related_services:
Line 91:                 if service.service_status(srv):


-- 
To view, visit http://gerrit.ovirt.org/20100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list