Change in vdsm[master]: Rescan FC when rescanning for new multipath devices

abaron at redhat.com abaron at redhat.com
Fri Oct 18 19:30:41 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: Rescan FC when rescanning for new multipath devices
......................................................................


Patch Set 5:

(1 comment)

....................................................
File vdsm/storage/multipath.py
Line 107:     Should only be called from hsm._rescanDevices()
Line 108:     """
Line 109: 
Line 110:     # First ask fc and iSCSI to rescan all of their sessions
Line 111:     fc.rescan()
in this case this patch set will probably cause a regression as I believe it is missing rescan of all non fc / iscsi scsi devices.

Also, issuing a lip will cause all I/O to be suspended which "- - -" avoids iirc and is the reason we avoided lip to begin with

Possibly we should just replace all of this with /usr/bin/rescan-scsi-bus.sh and differentiate between flows (i.e. not rescan everything every time, but have different calls depending on use case).
Line 112:     iscsi.rescan()
Line 113: 
Line 114:     # Now let multipath daemon pick up new devices
Line 115: 


-- 
To view, visit http://gerrit.ovirt.org/19539
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idec939222676a24452e8825b36db68839bfd2bbc
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list