Change in vdsm[master]: New getChildrenList implementation.

danken at redhat.com danken at redhat.com
Fri Oct 18 10:03:00 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: New getChildrenList implementation.
......................................................................


Patch Set 9: Code-Review+1

(1 comment)

....................................................
File vdsm/storage/fileVolume.py
Line 378:         metaPattern = os.path.join(domPath, 'images', '*', '*.meta')
Line 379:         metaPaths = oop.getProcessPool(self.sdUUID).glob.glob(metaPattern)
Line 380:         pattern = "%s.*%s" % (volume.PUUID, self.volUUID)
Line 381:         matches = grepCmd(pattern, metaPaths)
Line 382:         if matches:
I find Ayal's suggestion simpler and clearer. Though my favorite is 

 volMetas = (os.path.basename(line.split(':')[0]) for line in matches)
 return tuple(os.path.splitext(volMeta)[0] for volMeta in volMetas)

but that's no reason to block this patch imo.
Line 383:             children = []
Line 384:             for line in matches:
Line 385:                 volMeta = os.path.basename(line.split(':')[0])
Line 386:                 children.append(os.path.splitext(volMeta)[0])  # volUUID


-- 
To view, visit http://gerrit.ovirt.org/15765
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I584cd5d1b03d3965457f12c3d67de95455d1de24
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990 at gmail.com>
Gerrit-Reviewer: Gadi Ickowicz <gickowic at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list