Change in vdsm[master]: lvm: fix pv_count and pv_names check

danken at redhat.com danken at redhat.com
Thu Oct 17 13:14:33 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: lvm: fix pv_count and pv_names check
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

....................................................
File vdsm/storage/lvm.py
Line 410:                     vgsFields[uuid][pvNameIdx].append(pv_name)
Line 411:             for fields in vgsFields.itervalues():
Line 412:                 vg = makeVG(*fields)
Line 413:                 if int(vg.pv_count) != len(vg.pv_name):
Line 414:                     log.error("vg %s has pv_count %s but pv_names %s",
and it must be an annoying red-herring. Please backport to ovirt-3.3 branch!

It would be nicer if the commit message said so.
Line 415:                               vg.name, vg.pv_count, vg.pv_name)
Line 416:                 self._vgs[vg.name] = vg
Line 417:                 updatedVGs[vg.name] = vg
Line 418:             # If we updated all the VGs drop stale flag


-- 
To view, visit http://gerrit.ovirt.org/20196
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a3a2e7c7e5ddc4949eb690c1e4613284db9eafc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list