Change in vdsm[master]: Make link state change monitoring use an async proc

danken at redhat.com danken at redhat.com
Thu Oct 17 11:05:54 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Make link state change monitoring use an async proc
......................................................................


Patch Set 2:

Please avoid wild in-string lookups like this. This one, for example, would have caught a wrong line for a device called "54" if another device has 54:XX for and address.

-- 
To view, visit http://gerrit.ovirt.org/20259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief98bc08307652f541b7c9b87fca0499f9138b4f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list