Change in vdsm[master]: getIsoList() returns dict with files metadata
nsoffer at redhat.com
nsoffer at redhat.com
Tue Oct 15 11:47:29 UTC 2013
Nir Soffer has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
......................................................................
Patch Set 11: Code-Review+1
(2 comments)
Looks good except the API version that can be fixed when merging.
....................................................
File vdsm/storage/hsm.py
Line 2271: raise se.GetIsoListError(spUUID)
Line 2272:
Line 2273: fileStats = isoDom.getFileList(pattern='*.' + extension,
Line 2274: caseSensitive=False)
Line 2275: # Older clients expected list of file names with correct permissions.
Older clients are expecting a list; fix this if you need to post another patch.
Line 2276: fileNames = [key for key, value in fileStats.iteritems()
Line 2277: if value['status'] == 0]
Line 2278:
Line 2279: return {'isolist': fileNames, 'fileStats': fileStats}
....................................................
File vdsm_api/vdsmapi-schema.json
Line 3840: # @isolist: List of file names with proper permissions (for backward compatibility)
Line 3841: #
Line 3842: # @fileStats: Mapping with all file information
Line 3843: #
Line 3844: # Since: 4.14.0
Why 4.14?
Line 3845: ##
Line 3846: {'type': 'StorageDomainFileInfoMap',
Line 3847: 'data': {'isolist': ['str'], 'fileStats': 'StorageDomainFileStatsMap'}}
Line 3848:
--
To view, visit http://gerrit.ovirt.org/19544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list