Change in vdsm[master]: Drop evil exception swallowing form removeNic

danken at redhat.com danken at redhat.com
Tue Oct 15 09:49:08 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Drop evil exception swallowing form removeNic
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

....................................................
File vdsm/netconf/ifcfg.py
Line 604: 
Line 605:     def removeNic(self, nic):
Line 606:         cf = netinfo.NET_CONF_PREF + nic
Line 607:         self._backup(cf)
Line 608:         with open(cf)as nicFile:
hasn't pep8 bite you?
Line 609:             hwlines = [line for line in nicFile if line.startswith('HWADDR=')]
Line 610:         l = ['DEVICE=%s\n' % nic, 'ONBOOT=yes\n', 'MTU=%s\n' %
Line 611:              netinfo.DEFAULT_MTU] + hwlines
Line 612:         with open(cf, 'w') as nicFile:


-- 
To view, visit http://gerrit.ovirt.org/20179
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7e2ef5e75a4637110843e205753cef1110de8ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list