Change in vdsm[master]: Packaging: fix libvirt configuration

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Tue Oct 15 08:53:25 UTC 2013


Zhou Zheng Sheng has posted comments on this change.

Change subject: Packaging: fix libvirt configuration
......................................................................


Patch Set 1:

(3 comments)

Thanks.

This patch does not depend on http://gerrit.ovirt.org/#/c/20142/3 , but the children patches depend on both 20142/3 and the current one. I did not think of a better way to express this dependency.

....................................................
Commit Message
Line 8: 
Line 9: The help string "=FILE" is incorrectly added to the name of the
Line 10: configure option --with-libvirt-service-default. So This patch moves
Line 11: "=FILE" to help string.
Line 12: 
OK, thanks.
Line 13: Another problem is we disabled libvirt-sanlock in Ubuntu, so QLCONF is
Line 14: set to "/dev/null", but later we need to grep "${BY_VDSM_VERS}" from
Line 15: QLCONF to confirm libvirt is configured. grep returns 1 for QLCONF but
Line 16: actually libvirt is configured. This patch does not set QLCONF to


Line 14: set to "/dev/null", but later we need to grep "${BY_VDSM_VERS}" from
Line 15: QLCONF to confirm libvirt is configured. grep returns 1 for QLCONF but
Line 16: actually libvirt is configured. This patch does not set QLCONF to
Line 17: "/dev/null", this is harmless because when libvirt-sanlock is not
Line 18: enabled, no one reads and cares QLCONF actually.
Yes this is a problem.  Is it acceptable I change is_already_configured(), let it skip when "$1" is "/dev/null" ?
Line 19: 
Line 20: Change-Id: I34fa3764b999e71186171931664b0481b2ef3a15


....................................................
File lib/vdsm/tool/libvirt_configure.sh.in
Line 252:         set_if_default "${lconf}" listen_tcp 1
Line 253:         set_if_default "${lconf}" listen_tls 0
Line 254:     fi
Line 255: 
Line 256:     # Configuring sanlock
Hi Yaniv, ENABLE_LIBVIRT_SANLOCK is used here. So I think we can keep it.
Line 257:     if [ "${ENABLE_LIBVIRT_SANLOCK}" = "yes" ]; then
Line 258:         set_if_default "${qconf}" lock_manager \"sanlock\"
Line 259:         set_if_default "${qlconf}" auto_disk_leases 0
Line 260:         set_if_default "${qlconf}" require_lease_for_disks 0


-- 
To view, visit http://gerrit.ovirt.org/20168
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34fa3764b999e71186171931664b0481b2ef3a15
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list