Change in vdsm[master]: vdsm: move balloon logic out of buildConfDevices

mpoledni at redhat.com mpoledni at redhat.com
Tue Oct 15 07:49:42 UTC 2013


Martin Polednik has posted comments on this change.

Change subject: vdsm: move balloon logic out of buildConfDevices
......................................................................


Patch Set 4:

(2 comments)

....................................................
File vdsm/vm.py
Line 1873:                 devices[GENERAL_DEVICES].append(dev)
Line 1874: 
Line 1875:         # Update indices for drives devices
Line 1876:         self.normalizeDrivesIndices(devices[DISK_DEVICES])
Line 1877: 
getConfDevices is currently called inside buildConfDevices, where we initialize devices[BALLOON_DEVICES] to [], allowing us to move the call there
Line 1878:         return devices
Line 1879: 
Line 1880:     def buildConfDevices(self):
Line 1881:         """


Line 1936:                          'specParams': {
Line 1937:                              'model': 'none'}}
Line 1938: 
Line 1939:         # Avoid overriding the saved balloon target value on recovery.
Line 1940:         if 'recover' not in self.conf:
most of the code in vm.py uses this approach, is there any specific concern in this call? I'd rather keep the code unified and should we start with removal of direct conf access do it in larger refactoring patch
Line 1941:             for dev in balloonDevices:
Line 1942:                 dev['target'] = int(self.conf.get('memSize')) * 1024
Line 1943: 
Line 1944:         if not balloonDevices:


-- 
To view, visit http://gerrit.ovirt.org/19321
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6d77c1bbd7bdf760c8dda35d0ce6b70af51326bd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list