Change in vdsm[master]: gluster: Get size information of a gluster volume

smizrahi at redhat.com smizrahi at redhat.com
Mon Oct 14 13:57:41 UTC 2013


Saggi Mizrahi has posted comments on this change.

Change subject: gluster: Get size information of a gluster volume
......................................................................


Patch Set 7:

(1 comment)

....................................................
File client/vdsClientGluster.py
Line 444:     def do_glusterVolumeStatsInfoGet(self, args):
Line 445:         params = self._eqSplit(args)
Line 446:         volumeName = params.get('volumeName', '')
Line 447:         if not volumeName:
Line 448:             raise ValueError
Please raise a ValueError instance with some context perhaps though I see you don't do that all over so you guys might just like it this way.
Line 449: 
Line 450:         status = self.s.glusterVolumeStatsInfoGet(volumeName)
Line 451:         pp.pprint(status)
Line 452:         return status['status']['code'], status['status']['message']


-- 
To view, visit http://gerrit.ovirt.org/17822
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I358d4f3bf793ecc1a01e0592d68919d1405f6e19
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi at gmail.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: ndarshan <dnarayan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list