Change in vdsm[master]: logging: Add vdsm lvm log

smizrahi at redhat.com smizrahi at redhat.com
Mon Oct 14 09:11:42 UTC 2013


Saggi Mizrahi has posted comments on this change.

Change subject: logging: Add vdsm lvm log
......................................................................


Patch Set 4: Code-Review-2

I don't see any use for this.
The default lvm logs are no better then what we log anyway. You need to add -vvv so they are actually helpful.

This means that the logs you find on qa and clients servers will be practically useless.

Adding -vvv in the code will make the output be logged in main VDSM log when debugging.

That being said, even doing that is redundant as running the command yourself in terminal is the best way to debug lvm issues.

It's usually preferable to debug things directly and not from two layers up the stack.

I don't see a reason for this patch at all.

-- 
To view, visit http://gerrit.ovirt.org/20145
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7081bb8c1b1710dfa36ce56fac9ecd7a90fed1e3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list