Change in vdsm[master]: Introducing configurator package in vdsm-tool

Alon Bar-Lev alonbl at redhat.com
Sun Oct 13 14:15:48 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: Introducing configurator package in vdsm-tool
......................................................................


Patch Set 4:

(1 comment)

....................................................
File lib/vdsm/tool/configurator.py
Line 145:             if service.service_status(srv):
Line 146:                 service_should_start.append(srv)
Line 147: 
Line 148:     configure_libvirt(*args)
Line 149:     for srv in service_should_start:
I believe that best to do the start in reverse order.
Line 150:         service.service_start(srv)
Line 151: 
Line 152:     # sanlock configuration
Line 153:     if sanlock_check_service(*args) and force:


-- 
To view, visit http://gerrit.ovirt.org/20100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16bf5894e7e55a84b4c2a0caacde383ae7c19242
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list