Change in vdsm[master]: Avoiding automatically restart of sanlock service when start...

Alon Bar-Lev alonbl at redhat.com
Sun Oct 13 14:10:23 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: Avoiding automatically restart of sanlock service when starting vdsmd
......................................................................


Patch Set 11:

(1 comment)

....................................................
File init/vdsmd_init_common.sh.in
Line 50:     # If sanlock was started before the *first* installation of vdsm
Line 51:     # then it is probably missing the supplementary groups.
Line 52:     # Here we attempt to restart the service (when needed) to refresh
Line 53:     # the groups.
Line 54:     if "$VDSM_TOOL" sanlock-check-service; then
the tool should return success (0) if service is ok, something is not right either in message and return or in vdsm tool.
Line 55:         echo "Perform 'vdsm-tool service-restart sanlock' and start vdsm again"
Line 56:         return 1
Line 57:     fi
Line 58:     return 0


-- 
To view, visit http://gerrit.ovirt.org/19890
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48658066f707632719df8d65799d26c7b239dcd5
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list