Change in vdsm[master]: remoteFileHandler: config logging in spawned process

abaron at redhat.com abaron at redhat.com
Sun Oct 13 13:27:57 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: remoteFileHandler: config logging in spawned process
......................................................................


Patch Set 7:

(1 comment)

....................................................
File vdsm/storage/remoteFileHandler.py
Line 46: import misc
Line 47: import fileUtils
Line 48: import zombieReaper
Line 49: from vdsm import constants
Line 50: 
I'm not sure the complexity of it is worth the trouble considering http://gerrit.ovirt.org/14626 has been merged.
Can you show why this is needed after this patch?
Line 51: 
Line 52: # Crabs are known for their remote process calls
Line 53: LENGTH_STRUCT_FMT = "Q"
Line 54: LENGTH_STRUCT_LENGTH = calcsize(LENGTH_STRUCT_FMT)


-- 
To view, visit http://gerrit.ovirt.org/9182
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b3b9e2837d632c7532fcd8f7306ed50b0865b5c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list