Change in vdsm[master]: tests: refactor remoteFileHandler truncateFile tests

danken at redhat.com danken at redhat.com
Fri Oct 11 07:36:01 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: refactor remoteFileHandler truncateFile tests
......................................................................


tests: refactor remoteFileHandler truncateFile tests

The old test was too big, causing one test to fail if the other failed.
Now there are 2 separated tests, sharing setup, teardown and check
methods.

Additionally, creation of the test file is more correct, and the code is
hopefully more readable.

Change-Id: I0c23482e5d25651dc6090c7acfaa0ae221a562fe
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/20084
Reviewed-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/remoteFileHandlerTests.py
1 file changed, 24 insertions(+), 21 deletions(-)

Approvals:
  Nir Soffer: Verified
  Allon Mureinik: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/20084
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0c23482e5d25651dc6090c7acfaa0ae221a562fe
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list