Change in vdsm[master]: virtTests: fix initramfs permission detection

danken at redhat.com danken at redhat.com
Thu Oct 10 18:45:43 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: virtTests: fix initramfs permission detection
......................................................................


virtTests: fix initramfs permission detection

Initramfs and kernel permission was being detected using os.access
which caused running tests as root or user with permissions
to read initramfs and kernel when vdsm did not have these permissions
to fail the tests without creation if temporary initramfs
as os.access would see it as readable while it in fact was not.

This patch replaces os.access call with os.stat call,
which checks for permissions of >004 to make sure that
vdsm user can or can't read initramfs

Change-Id: I64316c727af529fd921553e2d8363b3946ad398d
Signed-off-by: Martin Polednik <mpoledni at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/20031
Reviewed-by: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Reviewed-by: Antoni Segura Puimedon <asegurap at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/functional/virtTests.py
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Martin Polednik: Verified
  Zhou Zheng Sheng: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/20031
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I64316c727af529fd921553e2d8363b3946ad398d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list