Change in vdsm[master]: Avoiding automatically restart of sanlock service when start...

ybronhei at redhat.com ybronhei at redhat.com
Thu Oct 10 14:57:45 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: Avoiding automatically restart of sanlock service when starting vdsmd
......................................................................


Patch Set 9:

(1 comment)

....................................................
File lib/vdsm/tool/configurator.py
Line 137:         service.service_stop("supervdsmd")
Line 138:         service.service_stop("libvirtd")
Line 139: 
Line 140:     if not configure_libvirt(*args):
Line 141:         sys.stderr.write("failed to run configure-libvirt\n")
errr now i recall. configure_libvirt already throws an RuntimeException if rc!=0 so it's not required here. leaving the call as it was in previous ps.
Line 142:     if sanlock_check_service(*args):


-- 
To view, visit http://gerrit.ovirt.org/19890
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48658066f707632719df8d65799d26c7b239dcd5
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list