Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...

danken at redhat.com danken at redhat.com
Thu Oct 10 13:34:41 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm hooks: this patch provides after/before_network_setup hooks.
......................................................................


Patch Set 4: Code-Review-1

Please note few nit-picking on PS2 and PS3.
Other than that, ACK.

I believe that the Jenkins failure are unrelated. Toni - could you help here?


Oct 10 11:43:59 jenkins-slave-vm01.ovirt.org vdsm[2744]: vdsm vds ERROR interface 'dummy_18' already member of network 'test-network'
Oct 10 11:43:59 jenkins-slave-vm01.ovirt.org vdsm[2744]: vdsm vds ERROR interface 'dummy_18' already has networks

-- 
To view, visit http://gerrit.ovirt.org/20076
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel at ajo.es>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel at ajo.es>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list