Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...
danken at redhat.com
danken at redhat.com
Thu Oct 10 12:53:53 UTC 2013
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm hooks: this patch provides after/before_network_setup hooks.
......................................................................
Patch Set 2:
(4 comments)
....................................................
File AUTHORS
Line 8: Federico Simoncelli <fsimonce at redhat.com>
Line 9: Saggi Mizrahi <smizrahi at redhat.com>
Line 10:
Line 11: Patches have also been contributed by (ordered by lastname):
Line 12:
trailing whitespace showing up as red in gerrit.
Line 13: Miguel Angel Ajo <miguelangel at ajo.es>
Line 14: Timothy Asir <tjeyasin at redhat.com>
Line 15: Haim Ateya <hateya at redhat.com>
Line 16: Daniel P. Berrange <berrange at redhat.com>
....................................................
File tests/Makefile.am
Line 104: apiData.py \
Line 105: monkeypatch.py \
Line 106: testrunner.py \
Line 107: testValidation.py \
Line 108: hookValidation.py
Please keep sorted, and add a trailing $(NULL) at the end.
Line 109:
Line 110: dist_vdsmtests_SCRIPTS = \
Line 111: run_tests.sh \
Line 112: testValidation.py \
....................................................
File vdsm/vdsmd.8.in
Line 63: .FN /usr/libexec/vdsm/hooks/<hook-name>/
Line 64: in lexicographic order.
Line 65:
Line 66: .SS Hook environment
Line 67: Each hook script (except before_vdsm_start, after_vdsm_stop, before_network_setup
please keep under 80 chars. It's easier to review.
Line 68: and after_network_setup)) inherit the environment of the VDSM process, with an
Line 69: additional variable
Line 70: .B _hook_domxml
Line 71: which holds the path of libvirt's
....................................................
File vdsm_hooks/Makefile.am
Line 100: after_disk_hotunplug \
Line 101: before_vdsm_start \
Line 102: after_vdsm_stop \
Line 103: before_network_setup \
Line 104: after_network_setup
Could you append $(NULL) here, too?
Line 105:
Line 106: all-local: \
Line 107: $(nodist_vdsmexec_SCRIPTS)
Line 108:
--
To view, visit http://gerrit.ovirt.org/20076
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel at ajo.es>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel at ajo.es>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list