Change in vdsm[master]: Avoiding automatically restart of sanlock service when start...

Alon Bar-Lev alonbl at redhat.com
Thu Oct 10 09:31:27 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: Avoiding automatically restart of sanlock service when starting vdsmd
......................................................................


Patch Set 9:

(2 comments)

....................................................
File lib/vdsm/tool/configurator.py
Line 98: 
Line 99:     try:
Line 100:         with open(sanlock_pid_file, "r") as f:
Line 101:             sanlock_pid = f.readline().strip()
Line 102:         sanlock_status = open(proc_status_path % sanlock_pid, "r")
I do not understand this comment...
Line 103:     except IOError as e:
Line 104:         if e.errno == os.errno.ENOENT:
Line 105:             sys.stdout.write("sanlock service is not running\n")
Line 106:             return retval  # service is not running, returning


Line 100:         with open(sanlock_pid_file, "r") as f:
Line 101:             sanlock_pid = f.readline().strip()
Line 102:         sanlock_status = open(proc_status_path % sanlock_pid, "r")
Line 103:     except IOError as e:
Line 104:         if e.errno == os.errno.ENOENT:
oh... understood.
Line 105:             sys.stdout.write("sanlock service is not running\n")
Line 106:             return retval  # service is not running, returning
Line 107:         raise
Line 108: 


-- 
To view, visit http://gerrit.ovirt.org/19890
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48658066f707632719df8d65799d26c7b239dcd5
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list