Change in vdsm[master]: Changing return method from vdsmd start function
zhshzhou at linux.vnet.ibm.com
zhshzhou at linux.vnet.ibm.com
Thu Oct 10 09:03:28 UTC 2013
Zhou Zheng Sheng has posted comments on this change.
Change subject: Changing return method from vdsmd start function
......................................................................
Patch Set 6:
(1 comment)
....................................................
File init/sysvinit/vdsmd.init.in
Line 67
Line 68
Line 69
Line 70
Line 71
I see. Thanks.
I use the form "! X || Y" because I think if a service is not existing or is not running, the overall stop conflicting operation should be considered successful.
I just have a vague memory that I add those parentheses to make operator precedence explicit, but it proves the parentheses are redundant.
--
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list