Change in vdsm[master]: Avoiding automatically restart of sanlock service when start...

ybronhei at redhat.com ybronhei at redhat.com
Thu Oct 10 08:30:15 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: Avoiding automatically restart of sanlock service when starting vdsmd
......................................................................


Patch Set 8:

(1 comment)

....................................................
File lib/vdsm/tool/configurator.py
Line 130:     if '--force' in args:
Line 131:         service.service_stop("supervdsmd")
Line 132:         service.service_stop("libvirtd")
Line 133: 
Line 134:     configure_libvirt(*args)
not really , if it fails it raises RuntimeException, if not the rc is 0. but I'll add it just for future changes , if someone will decide to return instead of raising exception
Line 135:     if sanlock_check_service(*args):


-- 
To view, visit http://gerrit.ovirt.org/19890
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48658066f707632719df8d65799d26c7b239dcd5
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list