Change in vdsm[master]: Ensure active LVs are refreshed before use.
abaron at redhat.com
abaron at redhat.com
Wed Oct 9 12:16:20 UTC 2013
Ayal Baron has posted comments on this change.
Change subject: Ensure active LVs are refreshed before use.
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
....................................................
File vdsm/storage/lvm.py
Line 1126: def activateLVs(vgName, lvNames):
Line 1127: lvNames = _normalizeargs(lvNames)
Line 1128: toActivate = [lvName for lvName in lvNames
Line 1129: if not _isLVActive(vgName, lvName)]
Line 1130: toRefresh = [lvname for lvname in lvNames if lvname not in toActivate]
instead of adding, just remove toActivate and add refresh option to setLVAvailability.
That way it would be in a single command (instead of multiple as you've implemented below) and would simplify the code as well.
Line 1131:
Line 1132: if toActivate:
Line 1133: _setLVAvailability(vgName, toActivate, "y")
Line 1134:
--
To view, visit http://gerrit.ovirt.org/19871
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list