Change in vdsm[master]: sd.py: Remove sds from sdCache when connecting

abaron at redhat.com abaron at redhat.com
Wed Oct 9 08:45:21 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: sd.py: Remove sds from sdCache when connecting
......................................................................


Patch Set 2: Code-Review+2

I just discussed this with Federico and the truth is the original patch seems better since it also solves any problems with FC domains.
The flow is that user activates the domain in engine:
this calls activateStorageDomain on SPM and then calls refreshStoragePool on all the HSMs.
refreshStoragePool already removes the domains from the cache (since we got a hint that something changed and we need to refresh it) and activateStorageDomain should not assume the object is ok since up until now the domain was not active, i.e. we haven't been monitoring it and it may have changed etc.
The flow in engine of activate is:
connectStorageServer (on spm)  - not called in case of FC
activateSD
connectStorageServer (on all hosts) - not called in case of FC
refreshStoragePool

The previous patch was (imo wrongly) nack'd by Edu.
I'm acking this one, but I would really prefer the original one.

-- 
To view, visit http://gerrit.ovirt.org/19995
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e0d0e970ce55acf92f7e39ec9cf2170e948274
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list