Change in vdsm[master]: reduce the time VM is paused in snapshot with RAM creation

danken at redhat.com danken at redhat.com
Tue Oct 8 20:36:01 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: reduce the time VM is paused in snapshot with RAM creation
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

-1 for visibility.

....................................................
Commit Message
Line 9: By using libvirt's VIR_DOMAIN_SNAPSHOT_CREATE_LIVE flag we minimize the
Line 10: time the VM is switched to paused state while creating live snapshot
Line 11: with RAM. Without this flag the VM is switched to pause state for the
Line 12: whole process of dumping the memory, and with this flag the VM is
Line 13: switched to pause state only for a short time.
Have you considered the down side of this flag? I suppose it may lead to unbounded dump size for a busy machine. Is you lv big enough?
Line 14: 
Line 15: Change-Id: Ieff4196e4514c15551aae5a2afe7e814b63f150c


-- 
To view, visit http://gerrit.ovirt.org/19296
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieff4196e4514c15551aae5a2afe7e814b63f150c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list