Change in vdsm[master]: vdsm: refactor buildConfDevices and getConfDevices into sing...

asegurap at redhat.com asegurap at redhat.com
Tue Oct 8 09:53:41 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: vdsm: refactor buildConfDevices and getConfDevices into single function
......................................................................


Patch Set 1:

(1 comment)

Very very minor thing, It's not necessary to do for this patch.

....................................................
File vdsm/vm.py
Line 1873:                    WATCHDOG_DEVICES: [],
Line 1874:                    CONSOLE_DEVICES: [],
Line 1875:                    SMARTCARD_DEVICES: []}
Line 1876:         # Build devices structure
Line 1877:         if self.conf.get('devices') is not None:
Just a minor thing. It is generally more readable to have is None and start with what now is in the else and then do the first block.
Line 1878:             for dev in self.conf.get('devices'):
Line 1879:                 try:
Line 1880:                     devices[dev['type']].append(dev)
Line 1881:                 except KeyError:


-- 
To view, visit http://gerrit.ovirt.org/19348
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd3a209967f97a55fe861c4446e8f93e1a1da08e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list