Change in vdsm[master]: vdsm: pre-defined range for spice/vnc ports

fsimonce at redhat.com fsimonce at redhat.com
Tue Oct 8 09:29:36 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: vdsm: pre-defined range for spice/vnc ports
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

....................................................
File lib/vdsm/tool/libvirt_configure.sh.in
Line 219:     fi
Line 220: 
Line 221:     # Configure remote display port range
Line 222:     set_if_default "${qconf}" remote_display_port_min 5900
Line 223:     set_if_default "${qconf}" remote_display_port_max 6411
I heard of boxes that are holding more 512 vms. Make sure we have clear error and let's make this configurable somewhere.
Line 224: 
Line 225:     # Configuring sanlock
Line 226:     set_if_default "${qconf}" lock_manager \"sanlock\"
Line 227:     set_if_default "${qlconf}" auto_disk_leases 0


-- 
To view, visit http://gerrit.ovirt.org/17058
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id42d41064e122f1b2dcc98506b58d0cc74239650
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list