Change in vdsm[ovirt-3.3]: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks

danken at redhat.com danken at redhat.com
Mon Oct 7 19:52:35 UTC 2013


Hello Vinzenz Feenstra, Michal Skrivanek, Martin Polednik,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/19949

to review the following change.

Change subject: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks
......................................................................

vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks

_getUnderlyingDriveInfo() is broken by design. It has no reliable means
to match Engine-requested devices with libvirt-produced ones. As a
heuristic, it uses the device's as matching key. However, before this
patch, it failed to extract the path from the xml definition of gluster
disks.

Bug-Url: https://bugzilla.redhat.com/1007980
Change-Id: I4459916cab24d735c067a6eb7020d4f43505fc97
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/19906
Reviewed-by: Vinzenz Feenstra <vfeenstr at redhat.com>
Reviewed-by: Michal Skrivanek <michal.skrivanek at redhat.com>
Reviewed-by: Martin Polednik <mpoledni at redhat.com>
Tested-by: Martin Polednik <mpoledni at redhat.com>
---
M vdsm/vm.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/19949/1

diff --git a/vdsm/vm.py b/vdsm/vm.py
index 4333170..d73671b 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -4562,7 +4562,8 @@
             sources = x.getElementsByTagName('source')
             if sources:
                 devPath = (sources[0].getAttribute('file') or
-                           sources[0].getAttribute('dev'))
+                           sources[0].getAttribute('dev') or
+                           sources[0].getAttribute('name'))
             else:
                 devPath = ''
 


-- 
To view, visit http://gerrit.ovirt.org/19949
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4459916cab24d735c067a6eb7020d4f43505fc97
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>


More information about the vdsm-patches mailing list