Change in vdsm[master]: Adding [start|stop]MonitoringDomain().

danken at redhat.com danken at redhat.com
Mon Oct 7 15:25:31 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Adding [start|stop]MonitoringDomain().
......................................................................


Patch Set 1:

(1 comment)

....................................................
File vdsm/storage/sp.py
Line 1545:         # {sdUUID1: status1, sdUUID2: status2, ...}
Line 1546:         self.invalidateMetadata()
Line 1547:         poolDoms = self.getDomains()
Line 1548:         activeDomains = tuple(sdUUID for sdUUID in poolDoms
Line 1549:                               if poolDoms[sdUUID] == sd.DOM_ACTIVE_STATUS)
I think that Eduardo is saying that we must not iterate over all monitoredDomains, but only on those connected to the pool. Hence

  poolDoms = self.getDomains()

is required, and to avoid races (and added metadata reads), a repeated call with 

  activeOnly=True

should not be used.
Line 1550:         monitoredDomains = self.domainMonitor.monitoredDomains
Line 1551: 
Line 1552:         for sdUUID in poolDoms:
Line 1553:             if sdUUID not in activeDomains:


-- 
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gadi Ickowicz <gickowic at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list