Change in vdsm[master]: getIsoList() returns dict with files metadata

danken at redhat.com danken at redhat.com
Mon Oct 7 15:01:20 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: getIsoList() returns dict with files metadata
......................................................................


Patch Set 7:

A gallant developer suggested that using the existing getFileList verb would be more fitting for this task, while keeping our API cleaner.

The only problem with using it NOW is that its current globbing is case-sensitive, while Engine would like it to be insensitive. This can be solved by passing a new option to control case sensitivity.

In https://bugzilla.redhat.com/show_bug.cgi?id=693218 Engine requested the getFileList verb. Maybe it's time to start using it?

I'm not stating my opinion as firmly as I should because I woke up late in the process of these reviews.

-- 
To view, visit http://gerrit.ovirt.org/19544
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list