Change in vdsm[master]: sd: unify lease params

abaron at redhat.com abaron at redhat.com
Mon Oct 7 13:23:22 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: sd: unify lease params
......................................................................


Patch Set 3:

(3 comments)

....................................................
File vdsm/storage/fileSD.py
Line 214:         # initialize domain metadata content
Line 215:         # FIXME : This is 99% like the metadata in block SD
Line 216:         #         Do we really need to keep the EXPORT_PATH?
Line 217:         #         no one uses it
Line 218:         meta = {}
if you're already changing the name, why not make it consistent with blockSD?
Line 219:         meta.update({
Line 220:             sd.DMDK_VERSION: version,
Line 221:             sd.DMDK_SDUUID: sdUUID,
Line 222:             sd.DMDK_TYPE: storageType,


Line 223:             sd.DMDK_CLASS: domClass,
Line 224:             sd.DMDK_DESCRIPTION: domainName,
Line 225:             sd.DMDK_ROLE: sd.REGULAR_DOMAIN,
Line 226:             sd.DMDK_POOLS: [],
Line 227:             sd.DMDK_LOCK_POLICY: '',
why not unify all of the above as well?
Line 228:             REMOTE_PATH: remotePath
Line 229:         })
Line 230:         meta.update(sd.SUB_DEFAULT_LEASE_PARAMS)
Line 231:         md.update(meta)


....................................................
File vdsm/storage/sd.py
Line 120: DMDK_LEASE_TIME_SEC = 'LEASETIMESEC'
Line 121: DMDK_IO_OP_TIMEOUT_SEC = 'IOOPTIMEOUTSEC'
Line 122: DMDK_LEASE_RETRIES = 'LEASERETRIES'
Line 123: 
Line 124: SUB_DEFAULT_LEASE_PARAMS = {DMDK_LEASE_RETRIES: 3,
I don't understand the name of this dict
Line 125:                             DMDK_LEASE_TIME_SEC: 60,
Line 126:                             DMDK_LOCK_RENEWAL_INTERVAL_SEC: 5,
Line 127:                             DMDK_IO_OP_TIMEOUT_SEC: 10}
Line 128: 


-- 
To view, visit http://gerrit.ovirt.org/16318
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id65d5dd2a0130a19234d7fb699854a09f5748566
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list