Change in vdsm[master]: Avoiding automatically restart of sanlock service when start...

Alon Bar-Lev alonbl at redhat.com
Mon Oct 7 12:37:38 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: Avoiding automatically restart of sanlock service when starting vdsmd
......................................................................


Patch Set 2:

(2 comments)

this patch if merge by its own breaks host-deploy.

....................................................
File init/sysvinit/vdsmd.init.in
Line 207:     reconfigure)
Line 208:         # Jump over 'reconfigure'
Line 209:         shift 1
Line 210:         reconfigure_libvirt "$@"
Line 211:         reconfigure_sanlock
what is the return if one fail? if two?
Line 212:     RETVAL=$?
Line 213:     ;;
Line 214:      *)
Line 215:     echo "Usage: $0 {start|stop|status|restart|force-reload|try-restart}"


....................................................
File init/vdsmd_init_common.sh.in
Line 56
Line 57
Line 58
Line 59
Line 60
should be:

 if ! "$VDSM_TOOL" sanlock-check-service; then
     echo "Perform 'vdsm-tool service-restart sanlock' and start vdsm again"
     return 1
 fi
 return 0

see bellow and above...


-- 
To view, visit http://gerrit.ovirt.org/19890
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48658066f707632719df8d65799d26c7b239dcd5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list